fix: replace bigint literals with BigInt constructors
#27930
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes web3.js compatible with runtimes that don't understand bigint literals but _do_ understand `BigInt` constructors. For whatever that's worth.
|
I'm not 100% sure we should do this. It's just a thought. |
jstarry
approved these changes
Sep 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #27930 +/- ##
=========================================
+ Coverage 77.3% 77.4% +0.1%
=========================================
Files 55 55
Lines 2889 2910 +21
Branches 402 404 +2
=========================================
+ Hits 2234 2255 +21
Misses 514 514
Partials 141 141 |
This was referenced Oct 11, 2022
This was referenced Oct 28, 2022
This was referenced Nov 9, 2022
This was referenced Nov 28, 2022
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some JavaScript runtimes support
BigIntbut not bigint literals.Summary of Changes
18446744073709551615nwithBigInt('0xffffffffffffffff')This makes web3.js compatible with runtimes that don't understand bigint literals but do understand
BigIntconstructors. For whatever that's worth.